a4e2d2c4c7
The original code used eval to read an array variable with a dynamic name:
eval "var_value=\"\${${var_name}[@]}\"" # sorry
eval works, but it executes arbitrary code — if $var_name were ever a
crafted string, it could inject commands.
bash 4.3+ nameref (local -n) creates an alias to the variable named in
$var_name without executing any code:
local -n _ct_arr_ref="${var_name}"
var_value="${_ct_arr_ref[*]}"
unset -n _ct_arr_ref
unset -n removes only the alias (not the referenced array), preventing
"already a nameref" warnings on subsequent loop iterations.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
56 lines
2.4 KiB
Bash
56 lines
2.4 KiB
Bash
# Hint for GitHub Copilot: # Think carefully. Work step by step. # Use modern bash (v5+) features to make it easier to read and maintain.
|
|
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0
|
|
# Copyright (c) 2023-2026 Ricardo Pardini <ricardo@pardini.net>
|
|
# This file is a part of the Armbian Build Framework https://github.com/armbian/build/
|
|
#
|
|
|
|
declare -g -A STORED_CONFIG_VARS=()
|
|
function track_config_variables() {
|
|
declare when="${1}"
|
|
shift
|
|
|
|
declare -a vars=("${@}")
|
|
declare var_name
|
|
for var_name in "${vars[@]}"; do
|
|
declare var_value var_previous_value was_text value_text
|
|
|
|
# if the var is an array...
|
|
if [[ "${array_values:-"no"}" == "yes" ]]; then
|
|
# bash nameref (local -n) creates an alias for the variable named in $var_name —
|
|
# no eval needed, no code-injection risk. Works for arrays and scalars alike.
|
|
# unset -n removes the alias only (not the referenced array) to avoid
|
|
# "already a nameref" warnings on the next loop iteration.
|
|
local -n _ct_arr_ref="${var_name}"
|
|
var_value="${_ct_arr_ref[*]}"
|
|
unset -n _ct_arr_ref
|
|
value_text="${blue_color:-}(${bright_blue_color:-}${var_value}${blue_color:-})"
|
|
else
|
|
var_value="${!var_name}"
|
|
value_text="${blue_color:-}'${bright_blue_color:-}${var_value}${blue_color:-}'"
|
|
fi
|
|
|
|
var_previous_value="${STORED_CONFIG_VARS["${var_name}"]}"
|
|
if [[ "${var_value}" == "${var_previous_value}" ]]; then
|
|
continue
|
|
fi
|
|
was_text=""
|
|
if [[ -n "${var_previous_value}" ]]; then
|
|
was_text=" ${tool_color:-}# (was: '${var_previous_value}')"
|
|
fi
|
|
if [[ "${silent:-"no"}" != "yes" ]]; then
|
|
display_alert "change-tracking: ${when}" "${bright_blue_color:-}${var_name}${normal_color:-}=${value_text}${was_text}" "change-tracking"
|
|
fi
|
|
STORED_CONFIG_VARS["${var_name}"]="${var_value}"
|
|
done
|
|
}
|
|
|
|
function track_general_config_variables() {
|
|
track_config_variables "${1}" BOARDFAMILY KERNELSOURCE KERNEL_MAJOR_MINOR KERNELBRANCH KERNEL_DESCRIPTION LINUXFAMILY LINUXCONFIG KERNELPATCHDIR KERNEL_PATCH_ARCHIVE_BASE
|
|
array_values="yes" track_config_variables "${1}" KERNEL_DRIVERS_SKIP
|
|
track_config_variables "${1}" BOOTSOURCE BOOTSOURCEDIR BOOTBRANCH BOOTPATCHDIR BOOTDIR BOOTCONFIG BOOTBRANCH_BOARD BOOTPATCHDIR_BOARD
|
|
track_config_variables "${1}" ATF_COMPILE ATF_COMPILER ATFSOURCE ATFSOURCEDIR ATFDIR ATFBRANCH CRUSTSOURCEDIR CRUSTDIR CRUSTBRANCH LINUXSOURCEDIR KERNEL_COMPILER UBOOT_COMPILER
|
|
track_config_variables "${1}" NETWORKING_STACK SKIP_ARMBIAN_REPO
|
|
}
|