65 lines
2.1 KiB
Diff
65 lines
2.1 KiB
Diff
From 8e69c52d77837dbd6c5ee8fda2af97ee5c1eacb0 Mon Sep 17 00:00:00 2001
|
|
From: Myy <myy@miouyouyou.fr>
|
|
Date: Sun, 12 Mar 2017 19:15:12 +0000
|
|
Subject: [PATCH 06/12] [Adaptation] ARM: dts: rockchip: fix the MiQi board's
|
|
LED definition
|
|
|
|
The MiQi board's green LED doesn't work at all with the mainline kernel.
|
|
There are multiple reasons to this. First, the gpio number is wrong, it
|
|
is declared on gpio220 (chip 7 pin 4) instead of gpio218 (chip 7 pin 2).
|
|
Second, a pinctrl is referenced, also declared with the same wrong value
|
|
while it is not unused. Third, the GPIO polarity was wrong (active low
|
|
instead of active high) with the default value set to "default-on",
|
|
resulting in the LED being turned off even when the GPIO is correct.
|
|
|
|
This patch fixes all these inconsistencies at once since these they are
|
|
related to each other, and also restores the "timer" trigger which is
|
|
the same as the one used by the kernels shipped with the board.
|
|
|
|
It's important to note that during the port to mainline, the led's label
|
|
was changed from "System" to "miqi:green:user", so scripts making use of
|
|
the name will still not work until they're fixed.
|
|
|
|
Fixes: 162718c (v4.7)
|
|
Cc: Heiko Stuebner <heiko@sntech.de>
|
|
Signed-off-by: Willy Tarreau <w@1wt.eu>
|
|
Signed-off-by: Myy <myy@miouyouyou.fr>
|
|
---
|
|
arch/arm/boot/dts/rk3288-miqi.dts | 12 ++----------
|
|
1 file changed, 2 insertions(+), 10 deletions(-)
|
|
|
|
diff --git a/arch/arm/boot/dts/rk3288-miqi.dts b/arch/arm/boot/dts/rk3288-miqi.dts
|
|
index 43728c9..7a42069 100644
|
|
--- a/arch/arm/boot/dts/rk3288-miqi.dts
|
|
+++ b/arch/arm/boot/dts/rk3288-miqi.dts
|
|
@@ -68,11 +68,9 @@
|
|
compatible = "gpio-leds";
|
|
|
|
work {
|
|
- gpios = <&gpio7 RK_PA4 GPIO_ACTIVE_LOW>;
|
|
+ gpios = <&gpio7 RK_PA2 GPIO_ACTIVE_HIGH>;
|
|
label = "miqi:green:user";
|
|
- linux,default-trigger = "default-on";
|
|
- pinctrl-names = "default";
|
|
- pinctrl-0 = <&led_ctl>;
|
|
+ linux,default-trigger = "timer";
|
|
};
|
|
};
|
|
|
|
@@ -363,12 +361,6 @@
|
|
};
|
|
};
|
|
|
|
- leds {
|
|
- led_ctl: led-ctl {
|
|
- rockchip,pins = <7 4 RK_FUNC_GPIO &pcfg_pull_none>;
|
|
- };
|
|
- };
|
|
-
|
|
sdmmc {
|
|
/*
|
|
* Default drive strength isn't enough to achieve even
|
|
--
|
|
2.10.2
|
|
|