Commit Graph

108 Commits

Author SHA1 Message Date
catalinii
f6143eff67
Fix the uboot for rock-3a (#3271)
* Sync kernel config with radxa and remove packaging patch

* Merge the rockchip64 legacy config as well

* Lower priority of EFI partitioning against DOS partitioning which is used by Armbian

Co-authored-by: Catalin Toda <catalinii@yahoo.com>
2021-12-25 11:57:26 -05:00
Ricardo Pardini
90e0fe0ba2
extensions framework + UEFI aarch64/x86 + rpi4b + core changes/fixes (#3300)
* extensions framework (née "fragments")

- this should actually change nothing at this point, just add capabilities
- the framework is implemented in lib/extensions.sh
- the "if function x exists then call x" replaced with call_extension_method()
  - +inline documentation
  - +compatibility names

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions framework; meta-extensions: auto-docs and sample extension gen

- 2 extensions dealing with extensibility itself
  - detect-unused-extensions: shows which extensions are enabled, but never called.
  - gen-sample-extension-docs: generates a sample empty extension & Markdown documentation for extensions

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* new extension methods and features via config variables in core Armbian

- `SKIP_EXTERNAL_TOOLCHAINS=yes` - does not download or use any linaro toolchains, only build host-installed ones
- `SKIP_BOOTSPLASH=yes` - does not patch kernel for splash file
- `EXTRA_BSP_NAME=xyz` - allows for BSP variants, useful for when extensions modify the BSP
- `EXTRA_ROOTFS_MIB_SIZE=x` - add x mib's to rootfs size, for use with very small images
- `KERNEL_EXTRA_TARGETS` - what extra targets to make kernel for, default to "modules dtbs"
- `BOOTCONFIG=none` - does not build nor install u-boot; also doesn't handle bootscripts et al
- `unset KERNELSOURCE` - does not build nor install kernel, nor build initrd, nor build nor install firmware
- `ARMHF_ARCH=skip` - does not add armhf to apt/dpkg, thus pure arm64
- `SKIP_ARMBIAN_REPO=yes` - results in armbian.list.disabled in the final image
- define `APT_EXTRA_DIST_PARAMS` with apt-cacher-ng options and use it for `PACKAGE_LIST_INSTALL/REMOVE` et al
- initial support for targeting x86/amd64 UEFI and BIOS
    - some do's/don'ts for x86/amd64, like a different `UBUNTU_MIRROR` default
    - GPT/EFI(ESP) partitions (fat, `UEFISIZE=256` to enable, mount `UEFI_MOUNT_POINT=/boot/efi`, first on disk but ends
      up at `$uefipart`=15)
    - GPT/BIOS partitions (fat, `BIOSSIZE=1` to enable, second on disk but ends up at partition 14)
    - `UEFI_FS_LABEL="armbiefi"` - to set the FAT label for the EFI partition, visible in Win/Mac
    - hard-requires gdisk package host-side
- add add_host_dependencies() extension method; fill `EXTRA_BUILD_DEPS="pkg pkg2"` to install to host before toolchains
  download
- add pre_prepare_partitions() extension method, for custom partition size calculations
- add create_partition_table() extension method, used to do full-custom partitioning if `USE_HOOK_FOR_PARTITION=yes`
- add post_create_partitions() extension method, mostly for easy debugging
- add post_write_sdcard() extension method, where you can also set `SKIP_VERIFY=yes` to skip sdcard verification
- add post_install_kernel_debs() extension method.
- multiple fixes to bsp to avoid spurious errors when files are not where it expects
- v4: detect `update-initramfs` failure and abort build with useful message if it does
- v4: show useful stacktrace in `exit_with_error`
  - if `ERROR_DEBUG_SHELL=yes`, drop into a shell before unmounting/deleting everything, so we can inspect what went wrong
- v4: display a message before `apt-get remove PACKAGE_LIST_BOARD_REMOVE` packages, so any errors while removing are easy to understand
- v4: preserve kernel .config's dates when copying

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions framework; refactor tool fetching/building into extensions

- a few examples of core refactoring using extensions
- sunxi-tools extension, enabled by 2 different sunxi family includes ("reuse" example)
- marvel-tools extension, enabled by 2 different mvebu family includes
- rkbin-tools extension, enabled by rockship64_common family include
- amlogic-fip/c2-blobs stuff refactored directly into meson64_common.inc ("single-use" example)
- removed the 'testings' fetch_from_repo completely since not used anywhere.

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* .wip's for UEFI arm64 and UEFI/BIOS x86 via new GRUB extension

- v3: added `growroot`-awareness to `armbian-resize-filesystem`
    - the partition-growing part of `armbian-resize-filesystem` does not deal correctly with the UEFI layout
    - `growroot` is installed on UEFI images by default, that handles growing partition during initramfs
    - now `armbian-resize-filesystem` handles `resize2fs` only, and works.
- v4: reworked UEFI board/family/include structure:
    - use Distro's `linux-generic` kernel only for `current`
    - `edge` now builds it's own pure-mainline `5.15.y` kernel, for both x86 and arm64
        - `.config` taken from Ubuntu, probably needs tuning for EXTRAWIFI=yes et al
- v4: introduce `SKIP_KERNEL_SYMLINK=yes`, tested in `builddeb`
    - to avoid symlinking kernel; u-boot likes it, but grub and flash-kernel hates it
- v5: many fixes
- v7: more small fixes.

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* .wip for the RaspberryPi 4B via new flash-kernel extension

- this does not build it's own kernel "yet", but uses default linux-raspi kernel from Ubuntu
- flash-kernel is not really a bootloader
    - it just prepares kernel et al a FAT partition for booting by the RPi4b bootloader
    - flash-kernel is standard Debian package, but has only been tested on Ubuntu releases
- it is really only known-working since Hirsute release.
  - Debian's rpi kernel is armhf only, so out of scope here, at least until we add source-built kernels.
- v3: fixed focal rootfs build. untested.
- v3: better variable names, preparing for source-built kernel.
- v5: new edge build with pure mainline kernel.
- v6: many fixes and some hacks for packaging and layout, also firmware (using Ubuntu's)

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* Added first patch to edge x86 related to wifi drivers

* extensions: leave hostapd alone; remove hackish ext; block reentrancy

- package-list-utils does not belong in this PR
- grub or bcm2711 is not the place to remove hostapd
- block recursive enable_extension() calls, for now.

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* gen-sample-extension-docs: fix: avoid counter in generated sample

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions: dependencies: enable_extension() in extensions with a stack

- and better stacktraces, I hope

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* Remove code from package list since we don't have it in repository
Adjust kernel config to disable driver that needs further polishing.

* Allow amd64 to build the same desktops as aarch64. We only have this limit for armhf, where some desktops don't work

* amd64: allow building amd64 on aarch64 with system toolchain

- conditionally add gcc-x86-64-linux-gnu to hostdeps

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* add libelf-dev directly to hostdeps (and Dockerfile), remove extension

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* packaging: remove SKIP_KERNEL_SYMLINK hack, fix the root cause

- which was the missing $image_name for non-arm64 & non-arm, so: x86 for example

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* grub: really obliterate u-boot stuff from BSP

- for now. soon we'll refactor u-boot so not have to do this

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* flash-kernel: really obliterate u-boot stuff from BSP

- for now. soon we'll refactor u-boot so not have to do this

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions: add host_dependencies_ready() hook

- this passes FINAL_HOST_DEPS containing all hostdeps for the run after they're installed

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* Add verification functions for correct selection.

* If UEFI Skip symlink creation

* Do not create dtb package for amd64

* Skip scripts folder cleaning if build process native.

Skip creating  postinst prerm scripts  for headers.

* Skip applying headers-debian-byteshift.patch if build native

* Fix architecture syntax as x86_64

* Revert "amd64: allow building amd64 on aarch64 with system toolchain"

This reverts commit 0c5ee20bb1.

* Compare architectures before starting compilation.



Signed-off-by: The-going <48602507+The-going@users.noreply.github.com>

* extensions: cleanups after fixes by the-Going

- packaging:
  - there is _no need_ anymore for the symlink hack, CONFIG_EFI or no. But check is great, see below
  - it's not `amd64` that has no DTB's, it's all UEFI, thus: `is_enabled CONFIG_EFI`, thanks!
- Explicitly disallow "reverse cross compile" in amd64.conf.
- whitespace-only-deletions: revert. we shall shellfmt the whole thing one day, but not today.
- fix a few syntax warnings in newly introduced code (floating `$ARCH` vs `"${ARCH}`) - blame shellcheck

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* packaging: fix: turns out a lot of boards have CONFIG_EFI=y, can't use that for dtb/no-dtb decision.

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* grub: remove debug

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* firmware: allow installing `armbian-firmware-full`; make it really full

- can now use `BOARD_FIRMWARE_INSTALL="-full"` to install full firmware for the board. enable for UEFI.
- don't rely on KERNELSOURCE for firmware-related decisions. introduce `INSTALL_ARMBIAN_FIRMWARE` which defaults to `yes`
- rpi4b/flash-kernel: disable Armbian firmware; we need linux-firmware-raspi2, which conflicts.

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions: log to /${LOG_SUBPATH}/ instead of fixed /debug/

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions: introduce cleanup_extension_manager() called by build-all-ng's unset_all()

- to reset/unset everything done by the the initializer, so build can run again

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions: remove 'global' logging, for use with build_all_ng

- enable_extensions() will have to live on without logging to file. it's just too early.
- now init EXTENSION_MANAGER_TMP_DIR in initialize_extension_manager()
- now init EXTENSION_MANAGER_LOG_FILE in initialize_extension_manager()

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* extensions: build-all-ng.sh bugfix due to extension's debug to stdout

- extensions (among other things) can produce output to stdout when activated
- fix: check_hash() produced "idential" (sic, now changed to IDENTICAL) to stdout as a trigger
- debugging output got mixed with "idential", rendering hash cache void for families that used extensions
  - eg: sunxi, others
- fix is to send stdout to the bitbucket when sourcing the board & arch config files
- proper fix would be stop using stdout in this case and use return code for check_hash()
  - one day soon

Signed-off-by: Ricardo Pardini <ricardo@pardini.net>

* Add CI build targets

Co-authored-by: Igor Pecovnik <igor.pecovnik@gmail.com>
Co-authored-by: The-going <48602507+The-going@users.noreply.github.com>
2021-12-06 09:49:49 +01:00
Igor Pecovnik
9e61b3a762
Implementing workaround for correct AUFS sources selection
Closes https://github.com/armbian/build/issues/3297
2021-11-29 11:59:13 +01:00
The-going
ada47377b5
Patches megous current branch to v5.10.82 (#3294)
* Kernel switch tag: v5.10.82
* Rework series megouse for v5.10.82
* Switch new packaging for kernel 5.10 and more
2021-11-28 21:31:24 +01:00
Vyacheslav
07523f5a9e
Add gpio power reset for hci_h5 controllers in h5_btrtl_open (#3208) 2021-10-19 21:02:24 +02:00
Bohdan
c8a68820d3
Add support for rtl8822cs (hci_ver 0x8) bluetooth (#3201)
Signed-off-by: chbgdn <chbgdn@gmail.com>
2021-10-18 20:36:28 +02:00
Igor Pecovnik
fbaeb940ca
Consolidate wireless driver related patch
Fixing troubles in https://github.com/armbian/build/pull/3154
2021-09-26 17:25:52 +02:00
Piotr Szczepanik
0069ad60a6
Preliminary support for rockchip rk35xx boards (#3111) 2021-09-15 22:08:39 +02:00
Vyacheslav
c3051b46ff
Add driver for Realtek 8822CS (SDIO) Wi-Fi adapter. (#3101) 2021-08-21 11:04:06 +02:00
Igor Pecovnik
4bc2dd27b1 Bugfix - disable wireless driver for older kernels and add a few upstream patches for meson64 legacy
Kernel was only tested for building.
2021-08-06 18:27:23 +02:00
Rob Logan
e2fa720f1d
Updated_Upstream_rtl88x2bu (#3083)
* Updated_Upstream_rtl88x2bu

* Updated_Upstream_rtl88x2bu
2021-08-06 08:19:09 +02:00
Icenowy Zheng
71a33a8a67
Re-enable 8723ds on 5.14 (#3076)
The lwfinger/rtl8723ds repo is already adapted to 5.14.

Re-enable 8723ds on 5.14.

Signed-off-by: Icenowy Zheng <icenowy@sipeed.com>
2021-08-03 18:04:52 +02:00
Igor Pecovnik
885a99fe66 Adjust and add upstream patches
- reenable 8723ds on K5.13 and remove deprecated wifi patches
- adjust rockchip audio and vdec patches in 5.13.y as in 5.10.y
2021-07-26 07:54:09 +00:00
Igor Pečovnik
e7377248b3
Second part of EDGE bumping to 5.13.y (#3045)
* Bump Meson64 EDGE to 5.13
* Bump Rockchip64 EDGE to 5.13.y
* Bump Odroid Xu4 edge to 5.13.y
* Bump rockchip edge to 5.13.y
2021-07-22 00:15:54 +02:00
Igor Pečovnik
e21e82b546
Upgrading sunxi, sunxi64, imx6, jetson-nano, mvebu and mvebu64 EDGE to 5.13 (#3042)
* Upgrading sunxi and sunxi64 EDGE to 5.13

Both variants tested for building

* Bump imx6 to 5.13.y

Tested

* Bump Jetson nano kernel to 5.13.y

* Move mvebu and mvebu64 edge to 5.13.y
2021-07-21 00:46:51 +02:00
Oleg
6bd67e18e5
add media kernel for arm64 (#2971) 2021-07-07 16:15:34 +02:00
Oleg
5b0dc2d7c5
add support wifi rtl8822bs for kernel 4.4 and 5.x (#2980) 2021-07-07 16:04:27 +02:00
Igor Pečovnik
fcb8b6f195
Code cleaning attempts (#2925)
* Move function run_on_sdcard to more appropriate location

* Focus on bash headers, unify, adjust (c)

* Adjust (c) to range

* Cleanup compile.sh

* Cleaning main

* Build all, main configs

* fine tunning

* Improve readme
2021-06-26 23:36:47 +02:00
Oleg
484a49a92c
fix wifi for p1 kernel 5.12 (#2921) 2021-06-25 23:33:13 +02:00
Oleg
2f2fd48345
fix wifi rtl8723ds (#2924) 2021-06-25 23:31:56 +02:00
Igor Pečovnik
3b3d85e25c
Upgrade EDGE to 5.12.y (#2825)
* Bump imx6 edge to 5.12.y

* Bump odroid xu4 edge to 5.12.y

* Bump Jetson nano edge to 5.12.y

* WIP: Bump sunxi to 5.12.y

- create a copy of patches and make a new link
- wireless patches needs adjutement to 5.12
- some patches are still failing

* Adjust wireless patches to build on 5.12.y

* Remove template wireless patch

* Move Espressobin edge to 5.12.y

* Bump mvebu to 5.12

- patch 92-mvebu-gpio-remove-hardcoded-timer-assignment.patch was disabled @heisath
- adjusted wireless driver for 8723ds

* Adjust sunxi / sunxi64 edge to compile

* Fix kernel config for Jetson nano edge

* bump meson64 to 5.12.y

* bump rockchip edge to 5.12.y

* Bump rockchip64 to 5.12.y

* Bump rk322x edge to 5.12.y

@paolosabatino

* Cleanup im6, re-add 5.10.y patches since one is missing in 5.12.y

* Update odroidxu4 edge links

* rk322x: moved rk322x-edge to kernel 5.12, fix overlay compilation, retouched included kernel modules

* Cleanup: remove deprecated config

Co-authored-by: Paolo Sabatino <paolo.sabatino@gmail.com>
2021-05-22 17:08:44 +02:00
The-going
8f1fb2e2be
Packaging (#2844)
* New build kernel if version ge 5.12

Signed-off-by: The-going <48602507+The-going@users.noreply.github.com>

* Rename packagename for kernel in the armbian style

Signed-off-by: The-going <48602507+The-going@users.noreply.github.com>

* Fix depends pkg for build linux-*

Signed-off-by: The-going <48602507+The-going@users.noreply.github.com>

* Fixed version search by Source field

Signed-off-by: The-going <48602507+The-going@users.noreply.github.com>

* Fix postinst, prerm scripts for headers pkg

Signed-off-by: The-going <48602507+The-going@users.noreply.github.com>
2021-05-22 17:01:29 +02:00
tim
cd0301cd62 Adjusting typo 2021-04-24 13:22:20 -04:00
Igor Pecovnik
f3a57d16d8 Enable AUFS on LK5.11 2021-03-28 12:19:43 +02:00
Oleg
d203ffee29
fix minor station (#2735) 2021-03-24 19:10:22 +01:00
Igor Pečovnik
54bc65b3bb
Bump DEV kernels to 5.11.y (#2636)
* Bump rockchip DEV 32b to 5.11.y

* Move mvebu64 DEV to 5.11.y

* Move Rockchip64 DEV to 5.11.y

Disabling general-rkvdec_nv15.patch - need more attention

* Add Meson DEV / Odroid C1

* Move OdroidXU4 DEV to tobetter's 5.11.y branch

* Bump sunxi DEV to 5.11.y

* Bump mvebu DEV to 5.11.y
2021-02-17 01:36:25 +01:00
Igor Pečovnik
d28c170a23
RTL 8811CU: Add support for K5.11.y (#2638)
* RTL 8811cu: Add support for K5.11.y
* Update configs and remove deprecated patches
2021-02-15 16:25:19 +01:00
Igor Pečovnik
03e4f604d3
Fixing out of the tree wireless driver compilation (#2635)
* Fix compilating on 5.10.y / 5.11.y for Realtek 8188EU

* Cleanup
2021-02-15 13:19:40 +01:00
Igor Pečovnik
514d213a64
Attach wireless driver back to master branch (#2634)
Checked compilation with 5.11.y
2021-02-15 13:19:31 +01:00
Igor Pečovnik
d95a4f7bf6
Enable AUFS back - its supported again (#2562)
* Enable AUFS back - its supported again

Tested building

* Update kernel configs for AUFS
2021-01-19 23:24:33 +01:00
Oleg
a1e96e68d8 add station legacy (#2521) 2021-01-04 11:51:43 +01:00
Igor Pecovnik
64a7867a65 Attach wireless driver to last known commit id
It breaks on 5.10.y
2020-12-31 01:40:53 +01:00
Igor Pecovnik
c7cc1825cd Update wifi related patches and (temprally) disable 8188EU since it breaks K5.10.y 2020-12-28 21:52:45 +01:00
Igor Pecovnik
cb5175ab36 Remove deprecated patch 2020-12-28 10:32:42 +01:00
Igor Pecovnik
11bc0ddf85 Revert "Disabling upgrade for USB network drivers for RTL8152/RTL8153"
This reverts commit 6bb68d7ff7.
2020-12-15 08:42:45 +01:00
Igor Pecovnik
6bb68d7ff7 Disabling upgrade for USB network drivers for RTL8152/RTL8153
Reported instability https://forum.armbian.com/topic/15165-nanopi-r2s-lan0-goes-offline-with-high-traffic/?do=findComment&comment=114522
2020-12-05 17:45:02 +01:00
Piotr Szczepanik
298b458d33
Support building 5.8.17+ and 5.9.2+ kernels (#2292) 2020-10-30 20:28:20 +01:00
5kft
56c7a6658a
implemented more changes for supporting kernel v5.10 2020-10-28 17:43:37 -07:00
5kft
9247f0dbf3
implemented initial packaging changes to support kernel v5.10 2020-10-27 17:19:29 -07:00
Igor Pecovnik
9b12d2907f Improve multicore build process by make use of overlays and uniqie temporally build directories 2020-10-21 15:31:32 +02:00
Igor Pečovnik
e8f961c9c7
Mitigate git server failures by retrying git commands several times. (#2251)
* Mitigate git server failures by retrying git commands several times.
* Bugfix - commit type was not working at all. Now it works
2020-10-14 08:36:21 +02:00
Igor Pecovnik
5bcd9c6ead Disable bootsplash support for kernel lower then 5.8.10 2020-09-21 19:59:59 +02:00
Igor Pečovnik
33d9a4cfc2
Rollback Linus changes related to software scrollback support which prevented bootsplash logo to show up (#2219)
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/video/fbdev/core?h=v5.8.10&id=20782abbbdfe922496a28f9cc0c3c0030f7dfb8f
2020-09-21 19:02:26 +02:00
lanefu
7b6920a25f
5.8.10 fixes (#2217)
* Update 0001-bootsplash.patch

dummyblit.c from patch/misc-001 will not compile with 5.8.10--

Change dummy_cursor  declaration in dummyblit.c in misc-001 to match changes in fbcon.h  see
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/video/fbdev/core/fbcon.h?h=v5.8.10&id=ffa74c8e58b8f42b2d95b29443befba2e28fb260

* Import bootsplash fix for kernel 5.8.10 from #2210 20a5631580

* simplifying assumption to kernel 5.8... will need ot make sure we patch up to 5.8.10

* corrected 5.8 bootsplash workaround

Co-authored-by: belfastraven <marti.packer@gmail.com>
2020-09-18 12:29:22 -04:00
lanefu
c3e9c7712b
5.8.10 fixes (#2212)
* Update 0001-bootsplash.patch

dummyblit.c from patch/misc-001 will not compile with 5.8.10--

Change dummy_cursor  declaration in dummyblit.c in misc-001 to match changes in fbcon.h  see
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/video/fbdev/core/fbcon.h?h=v5.8.10&id=ffa74c8e58b8f42b2d95b29443befba2e28fb260

* Import bootsplash fix for kernel 5.8.10 from #2210 20a5631580

* simplifying assumption to kernel 5.8... will need ot make sure we patch up to 5.8.10

Co-authored-by: belfastraven <marti.packer@gmail.com>
2020-09-17 23:55:01 -04:00
lanefu
6246bcfdbb
5.8.10 fixes (#2211)
* Update 0001-bootsplash.patch

dummyblit.c from patch/misc-001 will not compile with 5.8.10--

Change dummy_cursor  declaration in dummyblit.c in misc-001 to match changes in fbcon.h  see
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/video/fbdev/core/fbcon.h?h=v5.8.10&id=ffa74c8e58b8f42b2d95b29443befba2e28fb260

* Import bootsplash fix for kernel 5.8.10 from #2210 20a5631580

Co-authored-by: belfastraven <marti.packer@gmail.com>
2020-09-17 21:08:27 -04:00
5kft
49da9f087a
adapted kali-wifi-injection patches for kernel v5.9 2020-09-04 07:29:23 -07:00
5kft
275dca2040
ensure that external wireless driver Kconfigs are compatible with upcoming kernel kconfig keyword change
(see f70f74d15c)
2020-08-29 12:44:14 -07:00
5kft
359766b108 add RTL8192EU Wi-Fi adapter to the build 2020-08-12 14:48:26 -07:00
5kft
f526027b43
moved aircrack-ng/rtl8812au driver back to branch head (v5.6.4.2)
previous compilation issue was fixed with this change: b03bd4bc8d
2020-08-08 15:31:52 -07:00