Disabled uncontrollable power LED in Rock Pi 4

This commit is contained in:
Piotr Szczepanik 2019-08-01 18:12:42 +02:00
parent 5633ff6c9c
commit e015080fda

View File

@ -1,12 +1,16 @@
While mainlining Rock Pi 4 its leds were probably overlooked in the dts.
Power led is not usable by default but could possibly be made controllable
by its gpio with the help of soldering iron, good hands and patience (SMD0402).
Power led is not usable in currently available board revisions <= 1.4
and is disabled in dts to not confuse users who would like to fiddle with it.
It could possibly be made controllable by its gpio with the help
of soldering iron, steady hands, patience (SMD0402) and additional overlay
to enable the led and its gpio pin in device tree.
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
index e03062715..a97e02bc0 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dts
@@ -111,6 +111,24 @@
@@ -111,6 +111,25 @@
regulator-max-microvolt = <1400000>;
vin-supply = <&vcc5v0_sys>;
};
@ -20,6 +24,7 @@ index e03062715..a97e02bc0 100644
+ label = "power";
+ gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-on";
+ status = "disabled";
+ };
+
+ system-status {