enoch/armbian-build
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

(#9400 P1a) lib/functions/rootfs/distro-specific.sh: convert [ ] to [[ ]]

Browse Source 
Replace POSIX `[ ]` with bash `[[ ]]` on four conditionals: file/path
existence checks and an array length comparison.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Igor Velkov 2026-03-02 05:02:41 +02:00 committed by Igor
parent 2d1784eff0
commit 956aa02bf7
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/functions/rootfs/distro-specific.sh
View File

@ -79,7 +79,7 @@ function install_distribution_specific() {
install_rclocal
# use list modules INITRAMFS
if [ -f "${SRC}"/config/modules/"${MODULES_INITRD}" ]; then
if [[ -f "${SRC}/config/modules/${MODULES_INITRD}" ]]; then
display_alert "Use file list modules MODULES_INITRD" "${MODULES_INITRD}"
sed -i "s/^MODULES=.*/MODULES=list/" "${SDCARD}"/etc/initramfs-tools/initramfs.conf
cat "${SRC}"/config/modules/"${MODULES_INITRD}" >> "${SDCARD}"/etc/initramfs-tools/modules
@ -111,7 +111,7 @@ function fetch_distro_keyring() {
#FIXME: there may be a point where we need an *older* keyring pkg
# NOTE: this will be most likely an unsupported case like a user wanting to build using an ancient debian/ubuntu release
debian)
if [ -e "${CACHEDIR}/debian-archive-keyring.gpg" ]; then
if [[ -e "${CACHEDIR}/debian-archive-keyring.gpg" ]]; then
display_alert "fetch_distro_keyring($release)" "cache found, skipping" "info"
else
# for details of how this gets into this mirror, see
@ -138,7 +138,7 @@ function fetch_distro_keyring() {
fi
;;
ubuntu)
if [ -e "${CACHEDIR}/ubuntu-archive-keyring.gpg" ]; then
if [[ -e "${CACHEDIR}/ubuntu-archive-keyring.gpg" ]]; then
display_alert "fetch_distro_keyring($release)" "cache found, skipping" "info"
else
PKG_URL="https://github.armbian.com/keyrings/latest-ubuntu-keyring.deb"
@ -203,7 +203,7 @@ function create_sources_list_and_deploy_repo_key() {
Signed-By: /usr/share/keyrings/debian-archive-keyring.gpg
EOF
if [ ${#security_suites[@]} -gt 0 ]; then
if [[ ${#security_suites[@]} -gt 0 ]]; then
echo "" >> "${basedir}/etc/apt/sources.list.d/${distro}.sources" # it breaks if there is no line space in between
cat <<- EOF >> "${basedir}/etc/apt/sources.list.d/${distro}.sources"
Types: deb