From b9cf4cbe739e7e789ea73561fe874ebef5ac3ef6 Mon Sep 17 00:00:00 2001 From: Hamish Coleman Date: Thu, 26 Jan 2023 23:54:59 +0000 Subject: [PATCH 1/5] Provide ability to investigate build errors Upload the test results so they can be examined outside of the CI system --- .github/workflows/tests.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7d7b6bb..df4c42e 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -88,6 +88,13 @@ jobs: run: | make test + - if: ${{ failure() }} + name: Upload tests output + uses: actions/upload-artifact@v2 + with: + name: "analysis${{ matrix.flags }}" + path: tests + test_linux: needs: smoketest name: Test Linux From b1d2396cb9974bafef2f0ecbd211473d13dcf528 Mon Sep 17 00:00:00 2001 From: Hamish Coleman Date: Fri, 27 Jan 2023 00:08:32 +0000 Subject: [PATCH 2/5] Disable faling test - unreproducible locally, appears to be a github issue --- .github/workflows/tests.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index df4c42e..1f36d68 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -59,10 +59,14 @@ jobs: fail-fast: true matrix: flags: - - -fsanitize=leak - -fsanitize=address -static-libasan - -fsanitize=undefined -static-libubsan +# This option results in timeouts sending RPC requests during the +# test_integration_supernode.sh test when running in github actions. +# Disable it until more investigation can be done. +# - -fsanitize=leak + steps: - uses: actions/checkout@v2 with: From fadafabd66422d4c8b6b2273a995c60af076a26a Mon Sep 17 00:00:00 2001 From: Hamish Coleman Date: Fri, 27 Jan 2023 00:12:04 +0000 Subject: [PATCH 3/5] Address github workflow lint concerns --- .github/workflows/tests.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 1f36d68..b236197 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - name: Fix Checkout @@ -30,7 +30,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - name: Fix Checkout @@ -68,7 +68,7 @@ jobs: # - -fsanitize=leak steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - name: Fix Checkout @@ -108,10 +108,10 @@ jobs: matrix: os: - ubuntu-20.04 - - ubuntu-18.04 + - ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - name: Fix Checkout @@ -179,11 +179,11 @@ jobs: fail-fast: true matrix: os: - - macos-10.15 + - macos-12 - macos-11 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - name: Fix Checkout @@ -261,7 +261,7 @@ jobs: - windows-2022 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 - name: Fix Checkout @@ -324,7 +324,7 @@ jobs: - i386 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -370,7 +370,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -411,7 +411,7 @@ jobs: runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -449,7 +449,7 @@ jobs: - arm64-apple-macos steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -498,7 +498,7 @@ jobs: runs-on: macos-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -553,7 +553,7 @@ jobs: - mipsel-linux-gnu steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 @@ -612,7 +612,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: fetch-depth: 0 From b104f4a72d18716f4bd6ef1cd22ad27e11e28773 Mon Sep 17 00:00:00 2001 From: Hamish Coleman Date: Fri, 27 Jan 2023 00:21:14 +0000 Subject: [PATCH 4/5] Address lint concern --- .github/workflows/tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index b236197..5b1097d 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -62,10 +62,10 @@ jobs: - -fsanitize=address -static-libasan - -fsanitize=undefined -static-libubsan -# This option results in timeouts sending RPC requests during the -# test_integration_supernode.sh test when running in github actions. -# Disable it until more investigation can be done. -# - -fsanitize=leak + # This option results in timeouts sending RPC requests during the + # test_integration_supernode.sh test when running in github actions. + # Disable it until more investigation can be done. + # - -fsanitize=leak steps: - uses: actions/checkout@v3 From 914c450641d3fbdad59b99f43193ea12953c1225 Mon Sep 17 00:00:00 2001 From: Hamish Coleman Date: Fri, 27 Jan 2023 00:23:52 +0000 Subject: [PATCH 5/5] Address more github workflow lint concerns --- .github/workflows/tests.yml | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 5b1097d..6f68a26 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -94,7 +94,7 @@ jobs: - if: ${{ failure() }} name: Upload tests output - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: "analysis${{ matrix.flags }}" path: tests @@ -151,7 +151,7 @@ jobs: - if: ${{ failure() }} name: Upload tests output - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: tests-out path: tests @@ -163,13 +163,13 @@ jobs: shell: bash - name: Upload gcovr report artifact - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: coverage path: coverage - name: Upload data to codecov - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v3 test_macos: needs: smoketest @@ -222,7 +222,7 @@ jobs: - if: ${{ failure() }} name: Upload tests output - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: tests-out path: tests @@ -241,13 +241,13 @@ jobs: shell: bash # - name: Upload gcovr report artifact - # uses: actions/upload-artifact@v2 + # uses: actions/upload-artifact@v3 # with: # name: coverage # path: coverage - name: Upload data to codecov - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v3 test_windows: needs: smoketest @@ -296,7 +296,7 @@ jobs: - if: ${{ failure() }} name: Upload tests output - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: tests-out path: tests @@ -307,7 +307,7 @@ jobs: shell: bash - name: Upload data to codecov - uses: codecov/codecov-action@v2 + uses: codecov/codecov-action@v3 package_dpkg: name: Package for Debian/Ubuntu @@ -358,7 +358,7 @@ jobs: make - name: Upload dpkg - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: packages-dpkg path: packages/debian/*.deb @@ -399,7 +399,7 @@ jobs: mv ../rpmbuild ./ - name: Upload rpm - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: packages-rpm path: rpmbuild/RPMS/x86_64/*.rpm @@ -431,7 +431,7 @@ jobs: make install DESTDIR=binaries/x86_64-pc-mingw64 - name: Upload binary artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: binaries path: binaries @@ -475,7 +475,7 @@ jobs: - if: ${{ failure() }} name: Upload config.log output - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: config-log-${{ matrix.arch }} path: config.log @@ -486,7 +486,7 @@ jobs: make install DESTDIR=binaries/${{ matrix.arch }} - name: Upload binary artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: binaries path: binaries @@ -528,7 +528,7 @@ jobs: make install DESTDIR=binaries/universal-apple-darwin - name: Upload binary artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: binaries path: binaries @@ -583,7 +583,7 @@ jobs: make install DESTDIR=binaries/${{ matrix.arch }} - name: Upload binary artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: binaries path: binaries @@ -631,7 +631,7 @@ jobs: - name: Fetch all Artifacts if: steps.get_tagtype.outputs.TAGTYPE == 'tag' - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 with: path: artifacts