From 1464a7b4c3c0ecc65e99bcaecfd5aa0704ea2c91 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Igor=20Pe=C4=8Dovnik?=
 <igorpecovnik@users.noreply.github.com>
Date: Mon, 14 Nov 2022 14:58:04 +0100
Subject: [PATCH] Enable Shellcheck on changed files (#4431)

* Enable Shellcheck on changed files

On DIFF between PR and master

* Small improvement
---
 .github/workflows/lint-scripts-pr.yml | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/lint-scripts-pr.yml b/.github/workflows/lint-scripts-pr.yml
index 19dd734075..c842317e5f 100644
--- a/.github/workflows/lint-scripts-pr.yml
+++ b/.github/workflows/lint-scripts-pr.yml
@@ -6,7 +6,7 @@ name: Lint On Scripts
 on:
   workflow_dispatch:
   pull_request:
-    types: [review_requested, ready_for_review]
+    types: [review_requested, ready_for_review, opened, reopened, edited, synchronize]
 
 permissions:
   contents: read
@@ -26,18 +26,13 @@ jobs:
        - name: Environment variables
          run: sudo -E bash -c set
 
-       - name: "Shellcheck lint error report in diff format"
+       - name: "Shellcheck on changed files"
          shell: bash {0}
          run: |
 
-           (for file in $(find lib -type f -exec grep -Iq . {} \; -print); do shellcheck --format=diff $file; done;) 2> /dev/null > lib.diff || true
-           (for file in $(find packages -type f -exec grep -Iq . {} \; -print); do shellcheck --format=diff $file; done;) 2> /dev/null > packages.diff || true
-           (for file in $(find config -type f -exec grep -Iq . {} \; -print); do shellcheck --format=diff $file; done;) 2> /dev/null > config.diff || true
-
-       - name: Upload build artifacts
-         uses: actions/upload-artifact@v3
-         with:
-          name: Shellcheck
-          path: "*.diff"
-          if-no-files-found: ignore
-          retention-days: 14
+           for file in $(git diff --name-only master..HEAD); do
+           # We are only interested in BASH scripts
+           if grep -qE "#\!/" $file; then
+               shellcheck $file
+           fi
+           done