From 12ffcd6319ef5f92f551d734cb560eb4ce21c251 Mon Sep 17 00:00:00 2001
From: Ricardo Pardini <ricardo@pardini.net>
Date: Thu, 12 Jan 2023 15:47:30 +0100
Subject: [PATCH] armbian-oleg: curb `rsync` logging during bsp

---
 lib/functions/bsp/bsp-cli.sh           | 2 +-
 lib/functions/image/rootfs-to-image.sh | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/functions/bsp/bsp-cli.sh b/lib/functions/bsp/bsp-cli.sh
index d3ebc06f72..afd9b2ad5d 100644
--- a/lib/functions/bsp/bsp-cli.sh
+++ b/lib/functions/bsp/bsp-cli.sh
@@ -265,7 +265,7 @@ create_board_package() {
 	EOF
 
 	# copy common files from a premade directory structure
-	run_host_command_logged rsync -av ${SRC}/packages/bsp/common/* ${destination}
+	run_host_command_logged rsync -a ${SRC}/packages/bsp/common/* ${destination}
 
 	# trigger uInitrd creation after installation, to apply
 	# /etc/initramfs/post-update.d/99-uboot
diff --git a/lib/functions/image/rootfs-to-image.sh b/lib/functions/image/rootfs-to-image.sh
index 596a28a283..dce3523658 100644
--- a/lib/functions/image/rootfs-to-image.sh
+++ b/lib/functions/image/rootfs-to-image.sh
@@ -117,6 +117,8 @@ create_image_from_sdcard_rootfs() {
 		It is the last possible chance to modify `$CARD_DEVICE`.
 	POST_BUILD_IMAGE
 
+	# @TODO: using rsync is slow, and only needed if the source & the target are on different devices/filesystems
+	# @TODO: detect if on the same FS, if so, just "mv" which is a gazillion times faster
 	display_alert "Moving artefacts from temporary directory to its final destination" "${version}" "info"
 	[[ -n $compression_type ]] && run_host_command_logged rm -v "${DESTIMG}/${version}.img"
 	run_host_command_logged rsync -av --no-owner --no-group --remove-source-files "${DESTIMG}/${version}"* "${FINALDEST}"